Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: feat/initial-implementation #30

Closed
wants to merge 19 commits into from

Conversation

whizzzkid
Copy link
Contributor

fixes the node semver

@@ -15,8 +15,8 @@
"ipfs"
],
"engines": {
"node": ">=16.0.0",
"npm": ">=7.0.0"
"node": ">=18",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is broken on 16:

npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: 'semantic-release@20.1.0',
npm WARN EBADENGINE   required: { node: '>=18' },
npm WARN EBADENGINE   current: { node: 'v16.18.1', npm: '8.19.2' }
npm WARN EBADENGINE }
npm WARN deprecated sourcemap-codec@1.4.8: Please use @jridgewell/sourcemap-codec instead

Copy link
Member

@achingbrain achingbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this but it's the wrong place to fix it.

This section is set by the aegir check-project command and the changes here will be overwritten the next time that command is run.

Instead please see this comment for a link to where to open a PR to ensure the value is correct even after aegir check-project is run again.

@whizzzkid
Copy link
Contributor Author

Thanks @achingbrain https://github.com/ipfs/aegir/pull/1184/files, once this is merged, I'll use this PR for the new aegir version.

Base automatically changed from feat/initial-implementation to main February 13, 2023 15:49
@achingbrain
Copy link
Member

I'm going to close this PR as it only updates the node versions in the package.json files but is now full of conflicts because the PR it targeted has been squashed during the merge into main - it'll be simpler to open a new PR once ipfs/aegir#1184 is merged rather than try to fix the conflicts in this one.

@achingbrain achingbrain deleted the fix/feat/initial-implementation branch February 20, 2023 07:48
achingbrain added a commit to ipfs/aegir that referenced this pull request May 9, 2023
Refs: ipfs/helia#30

---------

Co-authored-by: Alex Potsides <alex@achingbrain.net>
achingbrain added a commit that referenced this pull request Jan 8, 2024
* deps(dev): bump aegir from 39.0.13 to 40.0.11

Bumps [aegir](https://github.com/ipfs/aegir) from 39.0.13 to 40.0.11.
- [Release notes](https://github.com/ipfs/aegir/releases)
- [Changelog](https://github.com/ipfs/aegir/blob/master/CHANGELOG.md)
- [Commits](ipfs/aegir@v39.0.13...v40.0.11)

---
updated-dependencies:
- dependency-name: aegir
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: achingbrain <alex@achingbrain.net>
achingbrain pushed a commit that referenced this pull request Jan 8, 2024
## [@helia/car-v1.0.2](https://github.com/ipfs/helia-car/compare/@helia/car-v1.0.1...@helia/car-v1.0.2) (2023-08-27)

### Dependencies

* **dev:** bump aegir from 39.0.13 to 40.0.11 ([#30](ipfs/helia-car#30)) ([ea26a0b](ipfs/helia-car@ea26a0b))
achingbrain added a commit that referenced this pull request Jan 8, 2024
Bumps [@helia/interface](https://github.com/ipfs/helia) from 1.2.2 to 2.0.0.
- [Release notes](https://github.com/ipfs/helia/releases)
- [Changelog](https://github.com/ipfs/helia/blob/main/CHANGELOG.md)
- [Commits](https://github.com/ipfs/helia/compare/@helia/interface-v1.2.2...helia-v2.0.0)

---
updated-dependencies:
- dependency-name: "@helia/interface"
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: achingbrain <alex@achingbrain.net>
achingbrain pushed a commit that referenced this pull request Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants