fix: use path gateway in default gateways #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2color
changed the title
SgtPooki
requested changes
Jan 11, 2024
SgtPooki
requested changes
Jan 16, 2024
Co-authored-by: Russell Dempsey <1173416+SgtPooki@users.noreply.github.com>
SgtPooki
approved these changes
Jan 16, 2024
|
Blocked until ipshipyard/waterworks-community#4 is resolved. |
SgtPooki
added
status/ready
|
this should be ready to be merged now |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fetching from subdomain gateways like cf-ipfs.com using path resolution returns a redirection (same thing with dweb.link) for every CID. This means an additional round trip for every CID requested.
This PR changes the default gateways to their path equivalent to avoid the additional round trip.
fixes #347