Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: verified-fetch etag header #434

Merged
merged 5 commits into from
Feb 16, 2024
Merged

fix: verified-fetch etag header #434

merged 5 commits into from
Feb 16, 2024

Conversation

SgtPooki
Copy link
Member

@SgtPooki SgtPooki commented Feb 14, 2024 •
edited
Loading

Fixes some issues with the etag header

FYI: should handle identity CID test is failing for me locally, even on main branch. no idea why. I npm run clean && npm i && npm run test and still get the failure I needed to npm run clean && npm i from the monorepo root.

@SgtPooki SgtPooki requested a review from a team as a code owner February 14, 2024 18:11
lidel
lidel approved these changes Feb 14, 2024
View reviewed changes
Copy link
Member

@lidel lidel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this Etag should be good enough and not cause trouble.

packages/verified-fetch/src/utils/get-e-tag.ts Outdated Show resolved Hide resolved
@SgtPooki @lidel
chore: jsdoc comment clarification
caa3530 
Co-authored-by: Marcin Rataj <lidel@lidel.org>
@SgtPooki @achingbrain
chore: import extension
4328559 
Co-authored-by: Alex Potsides <alex@achingbrain.net>
SgtPooki
SgtPooki commented Feb 15, 2024
View reviewed changes
Copy link
Member Author

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self review. should have done this yesterday. my bad. should be good to go now

@achingbrain achingbrain merged commit 8db7792 into main Feb 16, 2024
18 checks passed
@achingbrain achingbrain deleted the fix/verified-fetch-etag-header branch February 16, 2024 16:38
@achingbrain achingbrain mentioned this pull request Feb 16, 2024
Merged
@SgtPooki SgtPooki mentioned this pull request Apr 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achingbrain achingbrain achingbrain approved these changes

@lidel lidel lidel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SgtPooki @lidel @achingbrain