-
Notifications
You must be signed in to change notification settings - Fork 106
Meta
Steve Loeppky edited this page May 25, 2023
·
2 revisions
π Pros:
- Have full audit/version history
- Biases towards making changes/updates without incurring friction from the PR flow. Documentation is an area that usually is less catastrophic if you mess up and also something developers take less enjoyment out of. As a result, it makes sense to remove barriers here.
- Can easily edit with multiple interfaces (including Github GUI)
- Renders a highly visible table of contents by default so we don't spend time doing this manually or agreeing on the markdown tool to do it for us.
- Lives within Github where all the rest of the development work is done (no separate tool).
- Can easily link to sub-sections of a document
β Cons:
- Doesn't allow inline commenting.
- Not self-service for the community to contribute changes for review under PR.
- One can't easily get notifications of changes by "watching" the repo.
- There is no way to organize pages with sorting or directories
- While a strength above, it means that an accompanying documentation can't be in the PR for making a change
- Renaming a page causes all existing links to break.
Other options that were considered:
- Notion
- π Nice editing interface for making more polished docs
- π Inline commenting capability
- π Notifications
- π Seamless rename handling
- β Separate tool outside of github
- β Version history and revert isn't as clear/precise as with git
- Markdown files in a "docs" directory
- π Stay within github
- π Notification of changes
- β Friction of PR flow since we protect the main branch
- β Github rendering isn't as good since don't get nice/clear table of contents
- Github issues as docs
- π Stay within github
- ~ Can add comments to the stream
- β Can't link to specific sections within text (can only link to a specific comment)
- β Clutters issue tracker and inflates the number of "open" issues
Examples of good github wikis: https://github.com/MyHoneyBadger/awesome-github-wiki
In scope: anything that isn't catastrophic if it's off.
Out of scope:
- API Docs
Maintainers that are on the PL EngRes team sometimes use Notion for one-offs. This usually happens when need the features of Notion (inline commenting, databases). In general though we want to default to create content in GitHub for easier discoverability.