Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy window.ipfs examples #172

Open
2 of 6 tasks
lidel opened this issue Dec 14, 2020 · 1 comment
Open
2 of 6 tasks

Remove legacy window.ipfs examples #172

lidel opened this issue Dec 14, 2020 · 1 comment
Labels

Comments

@lidel
Copy link
Member

lidel commented Dec 14, 2020

ipfs/ipfs-companion#589 (comment):

The window.ipfs experiment was disabled since last year (see ipfs/ipfs-companion#777 for rationale why).

It did help us understand challenges and risks, and identified the need for more robust API for the web. We are officially putting window.ipfs experiment (in the form that was disabled in ipfs/ipfs-companion#777) in the Icebox and will be looking at other ways for node sharing and deduplication on the web in ipfs/in-web-browsers#158.

If we revisit this approach, it will be a more robust API tailored for use on the web,
and most likely happen after migration to Manifest V3 (ipfs/ipfs-companion#666).

Given that it has been off for most of this year and nobody complained,
I'll be removing its presence from our docs and codebases:

@jessicaschilling I can do the code cleanup, but you may be more familiar with the docs – is the page I linked the only place where we mention it?

@jessicaschilling
Copy link
Contributor

@jessicaschilling I can do the code cleanup, but you may be more familiar with the docs – is the page I linked the only place where we mention it?

@lidel - I added the remaining (quick) docs mods to your original checklist, plus a suggestion to move https://github.com/ipfs-shipyard/demo-ipfs-todo repo into the ipfs-inactive org. Let me know if you want help with the docs stuff.

lidel added a commit to ipfs/ipfs-companion that referenced this issue Feb 19, 2022
- removed yarn and all the hackery around transitive dependency overrides
- bumped all dependencies
- switched to ipfs-core for less deps
- removed unused deps
- Firefox manifest fix to pass latest webext lint
- removed remaining window.ipfs code that was pulling dead dependencies
  (ipfs/in-web-browsers#172)

TODO:
- fix tests
- docker builds
- browserAction icon
lidel added a commit to ipfs/ipfs-companion that referenced this issue Feb 19, 2022
- removed yarn and all the hackery around transitive dependency overrides
- bumped all dependencies
- switched to ipfs-core for less deps
- removed unused deps
- Firefox manifest fix to pass latest webext lint
- removed remaining window.ipfs code that was pulling dead dependencies
  (ipfs/in-web-browsers#172)

TODO:
- fix tests
- docker builds
- browserAction icon
@galargh galargh moved this to To do in IPFS-GUI (PL EngRes) Sep 22, 2022
lidel added a commit to ipfs/ipfs-companion that referenced this issue Sep 26, 2022
- removed yarn and all the hackery around transitive dependency overrides
- bumped all dependencies
- switched to ipfs-core for less deps
- removed unused deps
- Firefox manifest fix to pass latest webext lint
- removed remaining window.ipfs code that was pulling dead dependencies
  (ipfs/in-web-browsers#172)

TODO:
- fix tests
- docker builds
- browserAction icon
lidel added a commit to ipfs/ipfs-companion that referenced this issue Nov 22, 2022
- removed yarn and all the hackery around transitive dependency overrides
- bumped all dependencies
- switched to ipfs-core for less deps
- removed unused deps
- firefox manifest fix to pass latest webext lint
- removed remaining window.ipfs code that was pulling dead dependencies
  (ipfs/in-web-browsers#172)
- fixed tests (#1101)
- and much more

Co-authored-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants