docs: clarify subdomain CID normalization #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
autonome
approved these changes
Jun 16, 2020
hugomrdias
approved these changes
Jun 16, 2020
|
Added a couple of notes. I'm not too clear on the purpose of this doc. Is this a guide instructing the reader to do something? Or are we saying these things happen in this feature? |
johnnymatthews
suggested changes
Jun 16, 2020
Co-authored-by: Johnny <9611008+johnnymatthews@users.noreply.github.com>
|
I've applied suggestions from reviews. @johnnymatthews – mind taking a final look? |
johnnymatthews
suggested changes
Jun 19, 2020
|
The rest looks solid to me! Just that one tiny change 😄 |
Co-authored-by: Johnny <9611008+johnnymatthews@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds more detail into "best practices" when implementing
ipfs://URI backed by a subdomain gateway.Namely, opening a path with CID as-is, to take advantage of DNS normalization built into go-ipfs 0.5+
This should help with native URIs in Brave (brave/brave-browser#10220) when embedded go-ipfs is turned off and other collabs.