feat: next level of the datastore #2

dignifiedquire · 2017-03-12T23:53:41Z

No description provided.

daviddias · 2017-03-13T13:43:21Z

README.md


 ## License

-MIT


The README needs a reference to https://github.com/ipfs/go-datastore and also, list out all the methods that are not implemented, if any.

daviddias · 2017-03-13T13:44:29Z

flow-typed/npm/pull-stream_vx.x.x.js

+}
+declare module 'pull-stream/util/tester.js' {
+  declare module.exports: $Exports<'pull-stream/util/tester'>;
+}


Will every module that uses flow have to generate this? Should there be a flow-pull-stream package instead?

We should crate a definition and pr it to the flow-typed repo if we start using flow regularly yes, for now this is just a generated stub

Well, we can do that right now. pull-stream is part of the entire npm ecosystem, someone else will find it useful and it will save us space and time for when we decide to use it in other places.

I don't have the time right now to do it, we can create an issue for it

daviddias · 2017-03-13T13:46:09Z

package.json

-  "description": "datastore",
-  "main": "index.js",
+  "name": "interface-datastore",
+  "version": "1.0.0",


Let's keep at 0.1.0 until we have it all merged

daviddias · 2017-03-13T13:47:03Z

package.json

  ],
-  "author": "Juan Benet <juan@benet.ai> (http://juan.benet.ai/)",
+  "author": "Friedel Ziegelmayer <dignifiedquire@gmail.com>",


Well, Juan kind of created the whole thing.

Mind adding yourself as contributor?

Note, I don't think these things should be important.

daviddias · 2017-03-13T13:48:03Z

src/index.js

+
+export type Order<Value> = (QueryResult<Value>, Callback<QueryResult<Value>>) => void
+
+*/


Can all of this flow stuff be declared in a separate file?

I'd rather not, otherwise I have to change the type imports everywhere

daviddias · 2017-03-13T13:48:19Z

src/key.js

+ * - `new Key('/Comedy/MontyPython/Sketch:CheeseShop')`
+ * - `new Key('/Comedy/MontyPython/Sketch:CheeseShop/Character:Mousebender')`
+ *
+ */


This needs to go into the README

this is jsdoc, will go into the generated api docs, as we do with other api docs

I meant, the README needs to have more info about its API :)

daviddias · 2017-03-13T13:50:22Z

src/shard-readme.js

+with 'SC' being the last-to-next two characters and the 'B' at the
+beginning of the CIDv1 string is the multibase prefix that is not
+stored in the filename.
+`


Why is the readme a module?

Because it needs to be included in the code. it's written into the directories that use sharding

Interesting

daviddias

This module still has the different implementations inside it. But you also extracted some of them, let's extract all of them, making this module as light as possible.

dignifiedquire · 2017-03-13T13:54:40Z

This module still has the different implementations inside it. But you also extracted some of them, can we just start off by extracting all of them?

I extracted all backing implementations, I don't think it makes sense to put all these wrapping implementations into their own repos right now, it just makes things even more complex :(

dignifiedquire · 2017-03-13T14:59:29Z

Ref: ipfs/js-ipfs#787

daviddias · 2017-03-13T16:22:26Z

I extracted all backing implementations, I don't think it makes sense to put all these wrapping implementations into their own repos right now, it just makes things even more complex :(

Understood, that is because datastore has a lot of functionality, more than just using some storage backend. It seems that to make this clear we need

interface-datastore - interface definition and tests
js-datastore - implementation that has all of the functionalities
js-datastore-fs and js-datastore-level - the storage drivers that js-datastore can mount

dignifiedquire · 2017-03-13T16:29:45Z

Given that datastore is not available on npm, I would suggest js-datastore-core for the implementations, as datastore-core is available.

daviddias · 2017-03-13T16:32:09Z

@dignifiedquire go for it :)

dignifiedquire · 2017-03-13T17:26:15Z

@diasdavid extraction is done

dignifiedquire · 2017-03-14T21:34:54Z

@diasdavid updated readme to have more examples and api docs.

daviddias

The README is using flow notations, need to use our standard way of presenting the different types.

Other than that. LGTM

feat: next level of the datastore

c0286a3

dignifiedquire mentioned this pull request Mar 12, 2017

Ready for ipfs org dignifiedquire/js-datastore#13

Open

8 tasks

dignifiedquire added 4 commits March 13, 2017 00:55

chore: add license

c1c7eb6

feat(key): use buffers as underlying data source

b6d941b

fix(sharding): raw ops for fs backend

7c5a373

docs(readme): updates

2e17000

daviddias reviewed Mar 13, 2017

View reviewed changes

daviddias suggested changes Mar 13, 2017

View reviewed changes

dignifiedquire added 2 commits March 13, 2017 14:56

chore: address some of the cr

12ca197

chore: remove pull-stream stub for now

59d65f4

dignifiedquire added 2 commits March 13, 2017 17:33

feat: implement namespace store

fa171d8

extract wrapper implementations into js-datastore-core

69e9240

docs(readme): expand api docs

d4e693a

daviddias suggested changes Mar 15, 2017

View reviewed changes

docs(readme): use other method of describing types

6e86edc

daviddias approved these changes Mar 15, 2017

View reviewed changes

daviddias merged commit cf3b179 into master Mar 15, 2017

daviddias deleted the next branch March 15, 2017 11:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: next level of the datastore #2

feat: next level of the datastore #2

dignifiedquire commented Mar 12, 2017

daviddias Mar 13, 2017

daviddias Mar 13, 2017

dignifiedquire Mar 13, 2017

daviddias Mar 13, 2017

dignifiedquire Mar 13, 2017

daviddias Mar 13, 2017

daviddias Mar 13, 2017 •

edited

Loading

daviddias Mar 13, 2017

dignifiedquire Mar 13, 2017

daviddias Mar 13, 2017

dignifiedquire Mar 13, 2017

daviddias Mar 13, 2017

daviddias Mar 13, 2017

dignifiedquire Mar 13, 2017

daviddias Mar 13, 2017

daviddias left a comment •

edited

Loading

dignifiedquire commented Mar 13, 2017

dignifiedquire commented Mar 13, 2017

daviddias commented Mar 13, 2017

dignifiedquire commented Mar 13, 2017

daviddias commented Mar 13, 2017

dignifiedquire commented Mar 13, 2017

dignifiedquire commented Mar 14, 2017

daviddias left a comment


		export type Order<Value> = (QueryResult<Value>, Callback<QueryResult<Value>>) => void

		*/


		## License

		MIT

feat: next level of the datastore #2

feat: next level of the datastore #2

Conversation

dignifiedquire commented Mar 12, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

daviddias Mar 13, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

daviddias left a comment • edited Loading

Choose a reason for hiding this comment

dignifiedquire commented Mar 13, 2017

dignifiedquire commented Mar 13, 2017

daviddias commented Mar 13, 2017

dignifiedquire commented Mar 13, 2017

daviddias commented Mar 13, 2017

dignifiedquire commented Mar 13, 2017

dignifiedquire commented Mar 14, 2017

daviddias left a comment

Choose a reason for hiding this comment

daviddias Mar 13, 2017 •

edited

Loading

daviddias left a comment •

edited

Loading