This repository has been archived by the owner on Jun 19, 2023. It is now read-only.
fix: check errors by string #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
force-pushed
the
fix/check-error-as-string
branch
2 times, most recently
from
46bf30e to
c40a693
Compare
Unfortunately, we return errors over the HTTP API and lose the type.
Stebalien
force-pushed
the
fix/check-error-as-string
branch
from
c40a693 to
98e7257
Compare
aschmahmann
reviewed
Aug 17, 2021
| @@ -141,7 +139,7 @@ func (tp *TestSuite) TestInvalidPathRemainder(t *testing.T) { | |||
| } | |||
|
|
|||
| _, err = api.ResolvePath(ctx, path.New("/ipld/"+nd.Cid().String()+"/bar/baz")) | |||
| if err == nil || !errors.As(err, &resolver.ErrNoLink{}) { | |||
| if err == nil || !strings.Contains(err.Error(), `no link named "bar"`) { | |||
There was a problem hiding this comment.
We have to do this because there are HTTP API implementations of this interface (i.e.https://github.com/ipfs/go-ipfs-http-client) and we don't send the full type information over the wire.
So for now we're stuck with string checking the errors.
aschmahmann
approved these changes
Aug 17, 2021
guseggert
pushed a commit
to ipfs/boxo
that referenced
this pull request
Dec 6, 2022
…-error-as-string fix: check errors by string This commit was moved from ipfs/interface-go-ipfs-core@275b80e
guseggert
pushed a commit
to ipfs/boxo
that referenced
this pull request
Mar 15, 2023
…-error-as-string fix: check errors by string This commit was moved from ipfs/interface-go-ipfs-core@275b80e
Jorropo
pushed a commit
to ipfs/go-libipfs-rapide
that referenced
this pull request
Mar 23, 2023
…-error-as-string fix: check errors by string This commit was moved from ipfs/interface-go-ipfs-core@275b80e
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, we return errors over the HTTP API and lose the type.