fix: go-ipfs 0.5 sync #113
Conversation
hugomrdias
commented
May 20, 2020
•
hugomrdias
commented
- fix remote node ipfs http client path
- fix rabin params go-ipfs has validation and returns errors
- fix use cid instead of hash in the pin tests
hugomrdias
changed the title
| @@ -354,7 +354,7 @@ describe('files', function () { | |||
|
|
|||
| it('rabin chunker small chunks', () => { | |||
| const options = { | |||
| chunker: 'rabin-16-16-16', | |||
| chunker: 'rabin-16-32-64', | |||
There was a problem hiding this comment.
Why was this change necessary? rabin-16-16-16 seems to be supported by js and go:
$ ipfs add --chunker=rabin-16-16-16 ./package.json
added QmTUSudDKFYaVHLdU1wRoHYXkydQaDch4Kt8CwuVFShpiU package.json
$ jsipfs add --chunker=rabin-16-16-16 ./package.json
added QmTUSudDKFYaVHLdU1wRoHYXkydQaDch4Kt8CwuVFShpiU package.jsonThere was a problem hiding this comment.
api returns validation errors, min needs to bigger than avg, avg need to be smaller than max etc
There was a problem hiding this comment.
Which api? The js-IPFS api? Should probably fix that.
There was a problem hiding this comment.
Didn't confirm, but I'm assuming go http api we didn't change anything.
I will look into it
There was a problem hiding this comment.
Oh, no - I think you're correct, it's go-IPFS that's changed, I think I was running an old version just now (still 0.5.x but an old version from go-ipfs master):
$ ipfs add --chunker=rabin-16-16-16 ./package.json
Error: incorrect format: rabin-min must be smaller than rabin-avgThere was a problem hiding this comment.
@Stebalien was this change intentional?
There was a problem hiding this comment.
This chunker config is equivalent to a fixed-sized chunker. I'm not sure if this was intentional, but I'd like to leave it as it helps detect misuse of the chunker.
There was a problem hiding this comment.
added this item here ipfs/js-ipfs#3030 so we replicate in js-ipfs
