This repository has been archived by the owner on Aug 1, 2023. It is now read-only.
test: adds tests for adding and modifying mfs hamt shards #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Any chance you can rebase this and get some 💚 CI @achingbrain? |
achingbrain
force-pushed
the
add-tests-for-modifying-shards
branch
2 times, most recently
from
c9fcac0 to
0f1c506
Compare
|
I'm seeing some seemingly unrelated errors in CI: |
achingbrain
force-pushed
the
add-tests-for-modifying-shards
branch
from
0f1c506 to
f863b58
Compare
|
Will probably need a rebase after #68 goes in |
|
It's mostly green? |
|
Merging as test failures are unrelated. |
alanshaw
approved these changes
May 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires ipfs-inactive/js-ipfs-mfs#46 to be released.
I couldn't find a way to enable sharding for go and js without putting some conditionals in the daemon config - have I missed something?