Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add timing information to bitswap check #1

Merged
merged 1 commit into from
Aug 23, 2021
Merged

add timing information to bitswap check #1

merged 1 commit into from
Aug 23, 2021

Conversation

whyrusleeping
Copy link
Member

No description provided.

aschmahmann
aschmahmann approved these changes Aug 23, 2021
View reviewed changes
Copy link
Contributor

@aschmahmann aschmahmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok to me, but if we're going to try and reuse any of the vole libraries then either we'll have to move this into vole, or check the time on the checkBitswapCID command.

Fine to merge as is if you want since this whole codebase is WIP anyway.

@whyrusleeping whyrusleeping merged commit 2fe5a35 into main Aug 23, 2021
@aschmahmann aschmahmann deleted the feat/bitswap-timing branch January 3, 2022 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aschmahmann aschmahmann aschmahmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@whyrusleeping @aschmahmann