-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add telemetry #30
Conversation
fixes #28
ping @djmcquillan @whizzzkid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
const telemetry = new BrowserMetricsProvider({ appKey: 'b09437fd68bb257fef9b844a624fac0859b6224e' }) | ||
window.telemetry = telemetry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just wondering if this should be hook up automatically when BrowserMetricsProvider is init.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since these are only temporary (removed when #29 is done) I don't think so, but I'm open
@aschmahmann any comments before i merge this? How do we deploy this once merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SgtPooki not much to add here. Given the nature of the PR someone on your team is probably much better equipped to review than me.
The website itself should be auto-deployed by Fleek when you merge to master (it's managed by a PL account). I think it currently just deploys the "web" folder and doesn't need to do anything special, if that's changed as a function of this PR then you might need to change the Fleek configuration as well.
Also use minified telemetry.min.js instead of unminified telemetry.js. This resolves the need for a build step since ipfs-gui doesn't have access to the deployment environment.
lgtm with added telemetry.min.js |
fixes #28