fix: add form validation and mobile friendly scaling #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- set all fields to required - use placeholder instead of value to show example inputs - add viewport meta tag to ensure mobile devices use the responsive styles rather than scaling the entire page. License: (Apache-2.0 AND MIT) Signed-off-by: Oli Evans <oli@tableflip.io>
|
i'm done now. no more noodling. |
|
Thank you 🙏 |
aschmahmann
reviewed
Sep 23, 2021
| <label class="db mt3 f6 fw6" for="backendURL">Backend URL</label> | ||
| <input class="db w-100 pa2" type="text" id="backendURL" value="https://ipfs-check-backend.ipfs.io"> | ||
| <input class="db w-100 pa2" type="text" id="backendURL" value="https://ipfs-check-backend.ipfs.io" placeholder="https://ipfs-check-backend.ipfs.io" required> |
There was a problem hiding this comment.
This value needs to be passed in and the user rarely needs to change it (it's just to make it easy to point at another backend if ours is down or something). Will doing this make the user need to re-enter the data?
Maybe we leave this one alone, or we could just hard choice it into the JS or make it optional/implied and fix the JS to use it as the default.
There was a problem hiding this comment.
No is ok, the value is retained here. The placeholder is in addition, in case they delete the default, it will show them what the default used to be as a ghostly serving suggestion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
License: (Apache-2.0 AND MIT)
Signed-off-by: Oli Evans oli@tableflip.io