Do not cache dnslink lookup when API is offline

ipfs · Feb 4, 2016 · 2c37516 · 2c37516
1 parent 0d53002
commit 2c37516
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/lib/api.js b/lib/api.js
@@ -57,7 +57,7 @@ function isDnslinkPresent (fqdn) {
   try {
     xhr.send(null)
   } catch (e) {
-    return false
+    return null
   }
   if (xhr.status === 200) {
     let json = JSON.parse(xhr.responseText)
@@ -71,9 +71,11 @@ function isDnslinkPresentCached (fqdn) {
   let ipfsSupport = dnsCache.get(fqdn)
   if (typeof ipfsSupport === 'undefined') {
     ipfsSupport = isDnslinkPresent(fqdn)
-    dnsCache.put(fqdn, ipfsSupport)
+    if (ipfsSupport !== null) { // dont cache is API was down
+      dnsCache.put(fqdn, ipfsSupport)
+    }
   }
-  return ipfsSupport
+  return !!ipfsSupport
 }
 
 exports.apiUrl = apiUrl