Skip to content

Commit

Permalink
fix(mv3): CI Builds 🏗️ (#1183)
Browse files Browse the repository at this point in the history
* fix(mv3): 🩹 package.json

* fix(mv3): 🚨 Fix Lint

* fix(mv3): 💚 Manifest version

* feat: 🩹 temporary building from rc-branch
  • Loading branch information
whizzzkid authored Mar 24, 2023
1 parent 1ea8b09 commit f670059
Show file tree
Hide file tree
Showing 10 changed files with 39 additions and 2,518 deletions.
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ on:
pull_request:
branches:
- main
- rc/3.0-mv3

env:
XDG_CACHE_HOME: ${{ github.workspace }}/.cache
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:18.12.1
FROM node:18.14.0

ARG USER_ID
ARG GROUP_ID
Expand Down
2 changes: 1 addition & 1 deletion add-on/manifest.common.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
"dist/recovery/recovery.js"
],
"matches": [
"chrome-extension://*/*"
"<all_urls>"
]
}
],
Expand Down
2 changes: 1 addition & 1 deletion add-on/manifest.firefox-beta.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"applications": {
"browser_specific_settings": {
"gecko": {
"id": "ipfs-companion-dev-build@ci.ipfs.team",
"update_url": "https://ipfs-shipyard.github.io/ipfs-companion/ci/firefox/update.json"
Expand Down
4 changes: 2 additions & 2 deletions add-on/manifest.firefox.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@
"options_ui": {
"browser_style": false
},
"applications": {
"browser_specific_settings": {
"gecko": {
"id": "ipfs-firefox-addon@lidel.org",
"strict_min_version": "91.1.0"
"strict_min_version": "109.0.0"
}
},
"permissions": [
Expand Down
3 changes: 2 additions & 1 deletion add-on/src/background/background.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,5 @@ browser.runtime.setUninstallURL(getUninstallURL(browser))
const init = async () => {
await createIpfsCompanion()
}
init();

init()
6 changes: 3 additions & 3 deletions add-on/src/lib/ipfs-companion.js
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ export default async function init (windowedContext = false) {
throw new Error('IPFS Companion: API client is disabled')
}

function registerListeners() {
function registerListeners () {
const onBeforeSendInfoSpec = ['requestHeaders']
if (browser.webRequest.OnBeforeSendHeadersOptions && 'EXTRA_HEADERS' in browser.webRequest.OnBeforeSendHeadersOptions) {
// Chrome 72+ requires 'extraHeaders' for accessing all headers
Expand Down Expand Up @@ -263,7 +263,7 @@ export default async function init (windowedContext = false) {
}, 0)
}
}
info.currentDnslinkFqdn =await dnslinkResolver.findDNSLinkHostname(url)
info.currentDnslinkFqdn = await dnslinkResolver.findDNSLinkHostname(url)
info.currentFqdn = info.currentDnslinkFqdn || safeHostname(url)
info.currentTabIntegrationsOptOut = !state.activeIntegrations(info.currentFqdn)
info.isRedirectContext = info.currentFqdn && ipfsPathValidator.isRedirectPageActionsContext(url)
Expand Down Expand Up @@ -517,7 +517,7 @@ export default async function init (windowedContext = false) {
// Try SVG first -- Firefox supports it natively
await browser.action.setIcon(iconDefinition)
if (browser.runtime.lastError.message === 'Icon invalid.') {
throw browser.runtime.lastError
throw browser.runtime.lastError
}
} catch (error) {
// Fallback!
Expand Down
2 changes: 1 addition & 1 deletion add-on/src/recovery/recovery.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

import choo from 'choo'
import html from 'choo/html/index.js'
import browser, { i18n, runtime } from 'webextension-polyfill'
import { i18n, runtime } from 'webextension-polyfill'
import { nodeOffSvg } from '../landing-pages/welcome/page.js'
import createWelcomePageStore from '../landing-pages/welcome/store.js'
import { optionsPage } from '../lib/constants.js'
Expand Down
Loading

0 comments on commit f670059

Please sign in to comment.