Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sharing does not work in Firefox when opened in Private Window #477

Closed
lidel opened this issue May 11, 2018 · 0 comments
Closed

Sharing does not work in Firefox when opened in Private Window #477

lidel opened this issue May 11, 2018 · 0 comments
Assignees
@lidel
Labels
exp/novice Someone with a little familiarity can pick up kind/bug A bug in existing code (including security flaws) status/in-progress In progress
Milestone
v2.4.0

Comments

@lidel
Copy link
Member

lidel commented May 11, 2018 •
edited
Loading

screenshot_15

Brain dump:

  • This is Firefox-only. Chrome does not allow extensions in Incognito by default, and even if user opts in, clicking "Share" in Incognito opens a new tab in a regular, non-incognito window
  • I think this is due vendor blocking access to the background page in Private Window
  • An "ok" fix is to hide menu item when in Private Window.
@lidel lidel added kind/bug A bug in existing code (including security flaws) UX exp/novice Someone with a little familiarity can pick up labels May 11, 2018
@lidel lidel self-assigned this May 30, 2018
@lidel lidel added this to the v2.4.0 milestone May 30, 2018
@lidel lidel added the status/in-progress In progress label May 30, 2018
lidel added a commit that referenced this issue May 30, 2018
@lidel
fix: disable sharing action when upload is not possible
8f2a719 
Closes #477
@lidel lidel mentioned this issue May 30, 2018
Merged
lidel added a commit that referenced this issue May 30, 2018
@lidel
Merge pull request #488 from ipfs-shipyard/fix/private-window-sharing…
ae5ae58 
…-in-ff

fix: disable sharing action when upload is not possible

Closes #477 by disabling Upload action when access to required backend
is not possible  (eg. in Private Mode in Firefox).
lidel added a commit that referenced this issue Jun 15, 2018
@lidel
fix: hide unavailable actions in incognito mode
29d7bb1 
This commit solves some regressions related to background page access
being denied in incognito mode.

More context:
#477
#243
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lidel lidel

Labels
exp/novice Someone with a little familiarity can pick up kind/bug A bug in existing code (including security flaws) status/in-progress In progress
Projects
None yet
Milestone
v2.4.0
Development

No branches or pull requests
1 participant
@lidel