Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support configurable logger namespaces #712

Merged
merged 1 commit into from
Apr 17, 2019
Merged

Support configurable logger namespaces #712

merged 1 commit into from
Apr 17, 2019

Conversation

lidel
Copy link
Member

@lidel lidel commented Apr 16, 2019 •
edited
Loading

JS IPFS ecosystem is using debug for logs.

This PR supersedes #557 and adds support for latest debug in IPFS Companion:

  • Replaced console.log calls with debug-based log and log.error
  • Different parts of extension and JS IPFS stack log to own namespaces
  • User can tweak which logs should be printed to Browser Console using input on Preferences screen:

    2019-04-16--23-42-32

  • Setting Log Level to * will show all logs:

    2019-04-16--23-42-51

  • If Embedded node is used logs will include low level libp2p:

    2019-04-16--23-43-21

@ghost ghost assigned lidel Apr 16, 2019
@ghost ghost added the status/in-progress In progress label Apr 16, 2019
@lidel lidel force-pushed the feat/flexible-logger branch from 65b7862 to 1c557c4 Compare April 16, 2019 21:27
@lidel lidel marked this pull request as ready for review April 16, 2019 21:28
@lidel lidel mentioned this pull request Apr 16, 2019
Closed
1 task
@lidel
feat: configurable logger levels
972790e 
Replaced console.log calls with  'debug'-based logging.

Different parts of extension and JS IPFS stack log to own namespaces,
and user can tweak which logs should be printed to Browser Console
using input on Preferences screen.
@lidel lidel force-pushed the feat/flexible-logger branch from 1c557c4 to 972790e Compare April 17, 2019 11:14
@lidel lidel merged commit 0bf9f67 into master Apr 17, 2019
@lidel lidel deleted the feat/flexible-logger branch April 17, 2019 11:58
@ghost ghost removed the status/in-progress In progress label Apr 17, 2019
@lidel lidel mentioned this pull request Oct 17, 2019
Closed
@github-actions github-actions bot mentioned this pull request Feb 16, 2023
Closed
@github-actions github-actions bot mentioned this pull request Sep 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lidel lidel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lidel