Extension breaks in Chromium Dev Build 71.0.3578.98

[lidel]

Reported in #666 (comment) by @nonchip:

not sure if it's related to this but looks like it by the APIs involved:

on chromium Version 71.0.3578.98 (Developer Build) (64-bit) the extension breaks on activation with the attached log from the background script: nibjojkomfdiaoajekhjakgkdhaomnch-1555915381867.log

Unable to initialize addon due to error Error: 
Invalid value for argument 2. Property '.2': 
Value must be one of: [requestHeaders, blocking].

[lidel]

@nonchip Thank you for reporting this! I was unable to replicate this error with 75.0.3766.2 (so it is not related to #666).

I believe this error is caused by ipfs-companion requesting extraHeaders in onBeforeSendHeaders.

Chromium 72 made a breaking change and added extraInfoSpec, which explains why 71.x failed to recognize it:

src: https://developer.chrome.com/extensions/webRequest

How to fix?

There is minimum_chrome_version which we should add to non-Firefox manifest to avoid issues like this in the future (especially when Manifest v3 things start landing..)

@nonchip are you able to provide some context why are you still using Dev Build of 71.x ? is it shipped with some package manager, or did you just had it around for testing purposes? (Its quite old, I think current Stable ix 73.x)

[nonchip]

@lidel yeah turns out i didn't do an upgrade in some time, and apparently my distro's maintainer for this package is a bit lagging behind, current version in my repo is 72.0.3626.121

EDIT: upgraded to that and it works again

[lidel]

Cool! Let's keep this open until we have minimum_chrome_version in Manifest