Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression in HTTP recovery of background tabs #897

Closed
lidel opened this issue Jun 19, 2020 · 2 comments · Fixed by #915
Closed

Regression in HTTP recovery of background tabs #897

lidel opened this issue Jun 19, 2020 · 2 comments · Fixed by #915
Labels
effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) P3 Low: Not priority right now status/ready Ready to be worked

Comments

@lidel
Copy link
Member

lidel commented Jun 19, 2020

If a browser is configured to open links via middle click in the background (without switching active tab), then #876 has unexpected sideeffect:

Fix would be to find tabId that failed and explicitly update using explicit tabIt, instead of assuming it is active.
@lidel lidel added kind/bug A bug in existing code (including security flaws) help wanted Seeking public contribution on this issue good first issue Good issue for new contributors exp/novice Someone with a little familiarity can pick up P3 Low: Not priority right now status/ready Ready to be worked effort/hours Estimated to take one or several hours labels Jun 19, 2020
@lidel
Copy link
Member Author

lidel commented Jun 19, 2020 •
edited
Loading

iirc all that needs to be done is request.tabId needs to be passed as the first parameter of every browser.tabs.update call we make in ipfs-request.js

@quevas13
Copy link
Contributor

quevas13 commented Aug 9, 2020 •
edited
Loading

Hi,

I'm able to reproduce the bug and I'm working on it.

quevas13 pushed a commit to quevas13/ipfs-companion that referenced this issue Aug 9, 2020
fix: Regression in HTTP recovery of background tabs ipfs#897
613ef27
@quevas13 quevas13 mentioned this issue Aug 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) P3 Low: Not priority right now status/ready Ready to be worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: regression in HTTP recovery of background tabs quevas13/ipfs-companion
2 participants
@lidel @quevas13