-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(main): release 2.21.0 #1148
chore(main): release 2.21.0 #1148
Conversation
Looks like tag v2.21.0 points to -> 50dcfb1 which reads:
I dunno why that is, because, this https://github.com/ipfs/ipfs-companion/pull/1147/commits should've fixed it. Now we can look into moving the tag ahead of current commit. The fix looks like: https://stackoverflow.com/a/25849917/1114922 but maybe not worth the hassle. I think the last release that happened, the PR was missed. |
@@ -180,5 +180,6 @@ | |||
}, | |||
"ts-standard": { | |||
"project": "./tsconfig.json" | |||
} | |||
}, | |||
"version": "2.21.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lidel this needs to be skipped?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, why don't we have a version entry in the
package.json
?
It is a legacy thing (from the time before v2) – NPM was not very useful back then.
@whizzzkid I think it will be easier for interop with release tools if you move the "source of truth" for version to package.json
and then make sure the build applies value from package.json
to add-on/manifest.common.json
.
Ok to do that in the future PR.
50ba154
to
a4f6e91
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@whizzzkid I merged #1125. The code was added to this PR as expected, but information about #1125 was not added to "What's Changed" in the first comment of this PR and the CHANGELOG was also not updated.
We should fix this before making a release.
Closing this PR. |
🤖 I have created a release beep boop
What's Changed
New Contributors
Full Changelog: v2.20.1...v2.21.0
This PR was generated with Release Please. See documentation.