CI and Tests stabilization #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidel
force-pushed
the
fix/tests-timeout
branch
20 times, most recently
from
1de1bae to
8254370
Compare
- switched to glibc-based image - use specific yarn version - dedicated scripts to simulate ci build - `ci:install` runs yarn with `--frozen-lockfile` (immutable deps during CI build)
lidel
force-pushed
the
fix/tests-timeout
branch
3 times, most recently
from
ed1eb96 to
f817669
Compare
lidel
force-pushed
the
fix/tests-timeout
branch
from
f817669 to
0df4f31
Compare
lidel
force-pushed
the
fix/tests-timeout
branch
6 times, most recently
from
db1873a to
a59bf68
Compare
lidel
force-pushed
the
fix/tests-timeout
branch
from
a59bf68 to
72c56da
Compare
lidel
force-pushed
the
fix/tests-timeout
branch
3 times, most recently
from
4b81c9a to
cb52223
Compare
Give everyone the same permissions as the owner (root in docker)
lidel
force-pushed
the
fix/tests-timeout
branch
from
cb52223 to
7a0b460
Compare
Example of error in action: https://ipfs.io/ipfs/QmR7q6zkUt5WxWG2ATHJSVr1uMdpWk6hbjhC1EBy1duAvu When ci:install is run again, it works fine
lidel
force-pushed
the
fix/tests-timeout
branch
3 times, most recently
from
67edcf3 to
3357f14
Compare
lidel
force-pushed
the
fix/tests-timeout
branch
2 times, most recently
from
4b25b3d to
9adef29
Compare
plain text is easier to inspect / share
lidel
force-pushed
the
fix/tests-timeout
branch
from
9adef29 to
fc41ed1
Compare
|
@victorbjelkholm Any last concerns before I merge this? |
This will now work thanks to cleanWs()
This was referenced Feb 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to smoke-tests potential fixes for:
(ignore it for now, as I plan to rebase it until Jenkins and tests are 👌)