Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support HTTPS API endpoints #654

Merged
merged 1 commit into from
Jan 8, 2019
Merged

fix: support HTTPS API endpoints #654

merged 1 commit into from
Jan 8, 2019

Conversation

yvt
Copy link
Contributor

@yvt yvt commented Jan 8, 2019

This commit fixes the issue that a protocol name (http or https) is not passed to ipfs-http-client as intended.

Closes #652

This commit fixes the issue that a protocol name (http or https) is not passed
to `ipfs-http-client` as intended.

Closes ipfs#652
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@lidel lidel merged commit 8bb8a62 into ipfs:master Jan 8, 2019
lidel added a commit that referenced this pull request Apr 8, 2019
This fixes regresssion of #654 introduced by js-ipfs-http-client
ipfs-inactive/js-ipfs-http-client#959

Closes #706
lidel added a commit that referenced this pull request Apr 8, 2019
This fixes regresssion of #654 introduced by js-ipfs-http-client
ipfs-inactive/js-ipfs-http-client#959

Closes #706
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTTPS API endpoint is downgraded to HTTP
2 participants