Require Firefox 65.0 #713
Merged
Require Firefox 65.0 #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
js-ipfs-http-client does not seem to work as expected in Firefox <65 I confirmed v2.7.5 of ipfs-companion works fine, so I marked all following releases to require 65.0 or later This change updates minimal version in manifest, so new releases will not break Firefox ESR Userbase is small enough (~5% of firefox users) to just wait for the next ESR (in July)
ghost
assigned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
This change updates minimal version in manifest, so new releases will not break Firefox ESR.
Details
Browserfied js-ipfs-http-client does not seem to work as expected in Firefox <65
(
TypeError: response.body is undefinedaround this line, probably due to lack of Streaming APIs).Have no bandwidth to look into this, but I confirmed v2.7.5 of ipfs-companion works fine, so I marked all following releases to require 65.0 or later, making the last working version the default for ESR users.
ESR userbase is small enough (~5% of firefox users) to just wait for the next ESR scheduled to land in July.