feat: icon in browser action menu upon version update #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @lidel -- is this enough to get started? |
|
Thanks! I'll try to wire this up today 🤞 |
this hides new release notes indicator until new version is released and persists it until the newer release shipps it also converts old opt-out for opening releasenotes in a new tab to an opt-in
lidel
force-pushed
the
feat/new-version-alert
branch
from
2fa86be to
5b676e5
Compare
lidel
approved these changes
Oct 26, 2020
There was a problem hiding this comment.
LGTM! Thank you @jessicaschilling
- I've wired it up
- Turned out to be more involved than expected, mostly because choo does not support async render functions: I had to calculate show/hide flag in background page and then send it to the popup.
- Added migration from opt-out to opt-in
- If someone opts-in to opening release notes in a new tab, the redundant notification via icon won't be displayed.
Mind double checking if works as expected?
ps. while at it, mind eyeballing in Firefox? I see this weird cut-off, but it could be just my Linux box:
|
@lidel -- confirmed everything works as expected in both Chrome and Firefox on Mac. Also saw the same FF visual glitch, and adjusted icons' |
|
Look good in Firefox now, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #933.
To do
Note: There was discussion in #933 about changing the browser bar icon itself in some way to indicate the new version. Suggesting we leave this off (at least for now) - we have significant cube icon mods in #662 and I think the cube icon may be "full up" on its ability to convey different states once that issue is implemented.
Screenshot