feat: replace pinning with import to mfs #997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the way IPFS content is kept around. Instead of using low level pins we copy the item to MFS, unifying experience to match recent changes in ipfs-webui v2.12 and ipfs-desktop v0.15.0 This also removed page-action, because it was Firefox-specific feature and made maintenance and testing more difficult (now we have same UX in all browsers). Closes #742 Closes #888 Closes ipfs/ipfs-gui#91
lidel
commented
May 7, 2021
add-on/_locales/en/messages.json
Outdated
Comment on lines
86
to
91
| "panel_importCurrentIpfsAddress": { | ||
| "message": "Import to Files at My Node", | ||
| "description": "A menu item in Browser Action pop-up (panel_importCurrentIpfsAddress)" | ||
| }, | ||
| "panel_pinCurrentIpfsAddressTooltip": { | ||
| "message": "Pin this page's IPFS resources to your node to have a local copy that's available offline and never thrown away.", | ||
| "description": "A menu item tooltip in Browser Action pop-up (panel_pinCurrentIpfsAddressTooltip)" | ||
| "panel_importCurrentIpfsAddressTooltip": { | ||
| "message": "Import this tab's IPFS resource to your Files to have a persistent local copy that's available offline and never thrown away.", |
There was a problem hiding this comment.
@jessicaschilling this is the only change in UI, lmk if the label and tooltip explainer could be improved 🙏
There was a problem hiding this comment.
@lidel Maybe "on My Node" rather than "at"?
jessicaschilling
approved these changes
May 7, 2021
Co-authored-by: Jessica Schilling <jessica@protocol.ai>
Co-authored-by: Jessica Schilling <jessica@protocol.ai>
|
Thanks! Final look: This will confuse existing users who are used to seeing low level pin controls there, but the new flow is way more user-friendly and enables users to do remote pinning with UI from webui v2.12: ipfs/ipfs-gui#91 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way IPFS content is kept around.
Closes #742
Closes #888
Closes ipfs/ipfs-gui#91