Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: open directory from webui #1472

Merged
merged 1 commit into from
Apr 29, 2020
Merged

fix: open directory from webui #1472

merged 1 commit into from
Apr 29, 2020

Conversation

rafaelramalho19
Copy link
Contributor

Actions

Closes #1287

Notes

During some electron update, this function was probably left behind and didn't change from using callbacks to promises.

@rafaelramalho19 rafaelramalho19 added the kind/bug A bug in existing code (including security flaws) label Apr 29, 2020
@rafaelramalho19 rafaelramalho19 self-assigned this Apr 29, 2020
Copy link
Member

@hacdias hacdias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks gawd. It's the second time this happens! Thanks!

@hacdias hacdias merged commit e2a4aa2 into master Apr 29, 2020
@hacdias hacdias deleted the fix/upload-directory branch April 29, 2020 19:22
@lidel
Copy link
Member

lidel commented Apr 29, 2020

@rafaelramalho19 this is super important fix, thank you!

Ping me tomorrow and let's have a patch release party on Zoom to ship this fix as v0.11.2 🚢
(we'll go over steps at https://github.com/ipfs-shipyard/ipfs-desktop#releasing together, updating them if needed. now that we figured out notarization it should not take more than 1h 🤞)

@bertrandfalguiere
Copy link
Contributor

@lidel
Pulling all the translations mentioned here would be awesome :)

@lidel
Copy link
Member

lidel commented Apr 29, 2020

I know.. will try 😅

For sure we will update translations for Desktop itself, but may decide to not update webui ones, as that requires new release of webui + updating and releasing IPLD explorer deps, bubbling up everything, and that may be a time sink delaying this hotfix till next week, which we want avoid.

May push that to v0.11.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to add folders via Files screen
4 participants