fix: uppercase Discovery.MDNS.enabled in default config #1632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lidel do you think we should have ipfs desktop check for the incorrect key in the config, and remove it where it finds it? |
This cleans up configs of existing users As suggested in #1632 (comment) License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
|
Good question. Right now we only control the defaults applied on clean install. There is a need to have some generic way of migrating go-ipfs configs of existing users for things like @rafaelramalho19 @olizilla mind reviewing my changes? |
License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
lidel
approved these changes
Sep 10, 2020
hacdias
reviewed
Sep 11, 2020
|
|
||
| // Cleanup https://github.com/ipfs-shipyard/ipfs-desktop/issues/1631 | ||
| if (config.Discovery && config.Discovery.MDNS && config.Discovery.MDNS.enabled) { | ||
| config.Discovery.MDNS.Enabled = config.Discovery.MDNS.Enabled || true |
There was a problem hiding this comment.
no, user could remove it or explicitly set it to false to disable noise in LAN
|
Merging to unblock #1638 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1631