Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: include platform version in error report #2256

Merged
merged 1 commit into from
Sep 12, 2022
Merged

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Sep 5, 2022

Sometimes we need to know the user's platform (OS) version and not just which OS it is. This PR adds the os.release() to give us that information. Please note that this releases might not be 1:1 connected with the commercial names of the OSes. For macOS, for example, version 12.5, we get a kernel version of 21.6.0.

The other option, with more information, would be to print os.version(), which provides even more information:

> os.release()
'21.6.0'
> os.platform()
'darwin'
> os.version()
'Darwin Kernel Version 21.6.0: Wed Aug 10 14:28:23 PDT 2022; root:xnu-8020.141.5~2/RELEASE_ARM64_T6000'

I personally think os.version() would be better and more informative, but it is not as succinct. What do you think @lidel @SgtPooki?

@hacdias hacdias self-assigned this Sep 5, 2022
@hacdias hacdias added the need/maintainers-input Needs input from the current maintainer(s) label Sep 5, 2022
@hacdias hacdias marked this pull request as ready for review September 5, 2022 12:16
@SgtPooki SgtPooki merged commit 1105ca8 into main Sep 12, 2022
@SgtPooki SgtPooki deleted the feat/os-plat-release branch September 12, 2022 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need/maintainers-input Needs input from the current maintainer(s)
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants