Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Kubo: v0.19.2 #2474

Merged
merged 1 commit into from
May 5, 2023
Merged

Update Kubo: v0.19.2 #2474

merged 1 commit into from
May 5, 2023

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented May 3, 2023

This PR updates Kubo to v0.19.2

@hacdias hacdias requested review from a team, SgtPooki and whizzzkid as code owners May 3, 2023 10:01
@@ -76,7 +76,7 @@
"electron-updater": "^5.3.0",
"fix-path": "3.0.0",
"fs-extra": "^10.0.1",
"go-ipfs": "^0.19.1",
"go-ipfs": "^0.19.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't just updating the lock-file suffice because ^. I personally dislike ^ and ~.

This seems to be causing #2473 too, maybe just remove it and run npm i again?

Copy link
Member Author

@hacdias hacdias May 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an automatically generated PR by the way 😃 We can change that if you think it's a very important change in https://github.com/ipfs/kuboreleaser/issues

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hacdias if we could change it to be a hard-coded version in the auto-generated PR that would be great.

Copy link
Contributor

@whizzzkid whizzzkid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tentatively approving with thoughts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants