chore: update github actions #2520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whizzzkid
approved these changes
Jun 16, 2023
| continue-on-error: true # empty steps.tag.outputs.tag will inform the next step | ||
|
|
||
| - name: Build binaries with electron-builder | ||
| uses: samuelmeuli/action-electron-builder@92327c67bc45ff7c38bf55d8aa8c4d75b7ea38e7 # v1.6.0 but safer than a tag that can be changed | ||
| uses: paneron/action-electron-builder@14b133702d1b2e9749912051c43ed62b4afe56c8 # v1.8.1 |
There was a problem hiding this comment.
can we remove the old actions from: https://github.com/ipfs/ipfs-desktop/settings/actions?
There was a problem hiding this comment.
Will do, after the merge.
| @@ -133,7 +133,7 @@ jobs: | |||
| run: npm run test | |||
|
|
|||
| - name: Test end-to-end | |||
| uses: GabrielBB/xvfb-action@86d97bde4a65fe9b290c0b3fb92c2c4ed0e5302d # v1.6 | |||
| uses: coactions/setup-xvfb@b6b4fcfb9f5a895edadc3bc76318fae0ac17c8b3 # v1.0.1 | |||
There was a problem hiding this comment.
this looks like a downgrade?
There was a problem hiding this comment.
It's a different action so the versions are not really comparable. The one used here before is not longer maintained 😢
Hopefully not, as far as I can tell the operations should continue as before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://filecoinproject.slack.com/archives/C03KLC57LKB/p1686680229440949