Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: automate releases with release-please #2664
chore: automate releases with release-please #2664
Changes from all commits
c1bbebd
fd42cb3
a163d4f
3a05b24
aa22cc6
6756b1d
9dea6f7
5fed4fe
dd16b21
7451b0a
5d6daaa
cf4337a
8df6091
0c77858
114351b
ef06884
0e2b1a5
5404417
a5357e5
37a5173
a556d48
94f51f9
46c8eee
5de4fef
454daac
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the release please action can run both of these steps based on different context.
i.e. it'll run the release-pr step when a release PR does not exist and then it'll create a release in the next step.
One obv. question will be how will plugin work, you can have a check in the plugin to validate if it's in the PR creation phase or release creation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the plugin is in the PR creation phase and already validated in #2672
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm not sure if the other issues you brought up need looked at.. we could just call
npm run release-pr
ornpm run release-gh
appropriately where we need to?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does that also handle the tag-creation? combining steps simplifies maintainence.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the changes in this file are just changing repo strings from old ipfs-shipyard ones:
s/ipfs-shipyard\/ipfs-desktop/ipfs\/ipfs-desktop/