eslint-plugin-react@6.7.0 breaks build 🚨 #442
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello lovely humans,
eslint-plugin-react just published its new version 6.7.0.
This version is covered by your current version range and after updating it in your project the build went from success to failure.
As eslint-plugin-react is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.
I recommend you give this issue a high priority. I’m sure you can resolve this 💪
Of course this could just be a false positive, caused by a flaky test suite, or third parties that are currently broken or unavailable, but that would be another problem I’d recommend working on.
Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?
There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.
Good luck with your project ✨
You rock!
🌴
GitHub Release
Added
jsx-tag-spacing
rule (#693 @Kovensky)Fixed
jsx-indent
for parenthesized ternaries (#945 @voxpelli)jsx-indent
for multiline ternariesjsx-indent
for arrays in jsx (#947)no-danger-with-children
crash with spread on global variables (#921)jsx-wrap-multilines
ternaries handling (#916)Changed
no-unused-prop-types
skipShapeProps
option by default to limit false positive (#953 @everdimension)The new version differs by 85 commits .
5952dbf
Update CHANGELOG and bump version
17acf24
Update dependencies
874a3e3
Fix jsx-wrap-multilines ternaries handling (fixes #916)
fe5594b
Fix no-danger-with-children crash with spread on global variables (fixes #921)
1df6118
Merge pull request #953 from everdimension/default-skipshapeprops-enable
9921674
Fix some links in CHANGELOG
231acd9
Fix jsx-indent for arrays in jsx (fixes #947)
40882e5
Add more test to jsx-indent for multiline ternaries
2fb1d37
Fix jsx-indent on multiline ternary
e60921c
Fix jsx-indent for parenthesized ternary (fixes #945)
2cd6e91
skipShapeProps should be enabled by default until it works properly;
fd51133
[Refactor] extract
getTokenBeforeClosingBracket
to a file.56846a6
Merge pull request #707 from Kovensky/jsx-tag-spacing
1289239
Fix tests
dfbe2c1
Add simple example of correct closing slash
There are 85 commits in total. See the full diff.
This pull request was created by greenkeeper.io.
Tired of seeing this sponsor message? ⚡
greenkeeper upgrade