Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add circleci #552

Merged
merged 10 commits into from
Dec 21, 2017
Merged

chore: add circleci #552

merged 10 commits into from
Dec 21, 2017

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Dec 21, 2017

No description provided.

@hacdias hacdias merged commit ab320af into master Dec 21, 2017
@hacdias hacdias deleted the chore/circleci branch December 21, 2017 10:40
@victorb
Copy link
Member

victorb commented Dec 21, 2017

Not sure we really need CircleCI for station. In general we're moving all CI to Jenkins, but still using CircleCI for the repositories where it already was activated. However, if we didn't use CircleCI, it might be better to not add it. We're just doing linting, which should be platform-independent anyways, and right now this just adds builds to our queue, making CircleCI overall slower for us.

@hacdias
Copy link
Member Author

hacdias commented Dec 21, 2017

@victorbjelkholm sure thing. Can you disable it for me? It was @diasdavid who activated it and I don't think I have permission to change that.

@hacdias
Copy link
Member Author

hacdias commented Dec 21, 2017

What about AppVeyor @victorbjelkholm ?

@victorb
Copy link
Member

victorb commented Dec 21, 2017

@hacdias same thing there, it's just duplicating what we're already doing on jenkins + making the queues bigger. I'll disable both of them.

@hacdias
Copy link
Member Author

hacdias commented Dec 21, 2017

Thanks @victorbjelkholm! I'll remove the files then. Can you take a look here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants