Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes: use debug, correctly open settings and offline stats #585

Merged
merged 1 commit into from
Jan 11, 2018

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Jan 10, 2018

  • Use debugger instead of Winston.
  • Open the settings with openItem instead of openExternal.
  • Fixes offline stats.

Edit: just noticed that the daemon is always exiting with error on Windows.

@hacdias
Copy link
Member Author

hacdias commented Jan 10, 2018

@victorbjelkholm can you try running this branch to see if you "Node Settings" already work? 😄

@victorb
Copy link
Member

victorb commented Jan 11, 2018

I downloaded the .deb from https://ci.ipfs.team/blue/organizations/jenkins/IPFS%20Shipyard%2Fipfs-desktop/detail/PR-585/4/artifacts

First problem I hit was that I was running go-ipfs since before and ipfs-station just refused to start up. It should reuse the already running daemon if it exists.

Second issue I hit was that all the values were undefined since I wasn't connected to the internet. It should still list the Node ID, even though I cannot reach the internet.

Thirdly, "Node Settings" does open up a editor for editing the settings now.

==== Edit

Not sure ^ is new things, but things I noticed was broken in the build for this PR.

@hacdias
Copy link
Member Author

hacdias commented Jan 11, 2018

@victorbjelkholm

First problem I hit was that I was running go-ipfs since before and ipfs-station just refused to start up. It should reuse the already running daemon if it exists.

Ref.: #542. Will be easier after #549 gets merged.

Second issue I hit was that all the values were undefined since I wasn't connected to the internet. It should still list the Node ID, even though I cannot reach the internet.

Gonna check this tomorrow. 😄 Done!

Thirdly, "Node Settings" does open up a editor for editing the settings now.

Awesome!

Not sure ^ is new things, but things I noticed was broken in the build for this PR.

Sometimes the build just fails... I'll restart it. Passed now.

@hacdias
Copy link
Member Author

hacdias commented Jan 11, 2018

@victorbjelkholm btw, you can now run this with DEBUG=desktop yarn start to see the log. Could you check if you can find out the reason why IPFS is being killed now?

@hacdias hacdias changed the title fixes: many™ fixes: use debug, correctly open settings and offline stats Jan 11, 2018
@hacdias hacdias requested review from victorb and daviddias and removed request for victorb and daviddias January 11, 2018 09:37
@hacdias hacdias merged commit 2aaec20 into master Jan 11, 2018
@hacdias hacdias deleted the some-fixes branch January 11, 2018 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants