Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: i18n #706

Merged
merged 3 commits into from
Nov 23, 2018
Merged

feat: i18n #706

merged 3 commits into from
Nov 23, 2018

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Nov 23, 2018

Basically done. The locales are on src/locales. @lidel would you help me by setting up Transifex for IPFS Desktop? 😄

closes #650

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
@ghost ghost assigned hacdias Nov 23, 2018
@ghost ghost added the in progress label Nov 23, 2018
@ghost ghost assigned lidel Nov 23, 2018
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

I've added .tx/config and a project at https://www.transifex.com/ipfs/ipfs-desktop/
Created pl locale to smoke-test the process, and main menu is translated as expected.

When this PR is merged to master I will set up automatic sync of source strings.

ps. For some reason embedded Web UI stays in English for me, but I did not dig into it. Anyone is able to reproduce? If it is a bug, can be fixed in separate PR.

@hacdias
Copy link
Member Author

hacdias commented Nov 23, 2018

@lidel maybe the language detector we use for Web UI can't detect the correct language of the system. I'll try out on my computer but I believe that a change on preload script will be able to solve that :)

@hacdias hacdias merged commit 123738d into master Nov 23, 2018
@ghost ghost removed the in progress label Nov 23, 2018
@hacdias hacdias deleted the i18n branch November 23, 2018 20:46
@hacdias
Copy link
Member Author

hacdias commented Nov 23, 2018

@lidel merged. I will check out the Web UI issue now!

@lidel
Copy link
Member

lidel commented Nov 24, 2018

@hacdias Thanks! I've set up automatic sync. New strings added to src/locales/en.json in master branch will appear on Transifex within 24h 👌

2018-11-24--02-22-39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make it i18n friendly
2 participants