Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve dialogs UX #919

Merged
merged 4 commits into from
Apr 28, 2019
Merged

feat: improve dialogs UX #919

merged 4 commits into from
Apr 28, 2019

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Apr 28, 2019

This:

  1. Improves dialogs UX on all OSes.
  2. Cleans up the code a bit and moves more strings to i18n.
  3. Adds a dialog when the user tries to do some action that requires the daemon to be turned on (screenshot, add files, download hash) with the option to turn it on.
  4. A nice read: https://medium.muz.li/ok-key-and-cancel-key-which-one-should-be-set-up-on-the-left-4780e86c16eb
  5. Updates the signature of the getIpfsd function. By default, it assumes the code really needs the object so if it doesn't exist, the user will be asked to turn IPFS on. We can pass a true value as argument to make it optional.

…s ipfs

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
@ghost ghost assigned hacdias Apr 28, 2019
@ghost ghost added the in progress label Apr 28, 2019
License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
@hacdias hacdias merged commit 3a8154a into master Apr 28, 2019
@ghost ghost removed the in progress label Apr 28, 2019
@hacdias hacdias deleted the feat/dialog-ux branch April 28, 2019 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant