-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: mention kubo-rpc-client #1299
Conversation
Thank you for submitting this PR!
Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. |
We shouldn't block, but I added @achingbrain . I also put the IPFS doc writer: @TMoMoreau . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, if we address small issues described below
Co-authored-by: Marcin Rataj <lidel@lidel.org>
@TMoMoreau ready to merge after CI passes if you're good with the changes requested by lidel that I've addressed. |
@TMoMoreau / @SgtPooki : lets get this merged :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TMoMoreau is out until mid next week. We can merge on his behalf. Just a small nit on how the APIs are referenced.
@SgtPooki left a minor suggestion |
Thanks for pushing this over the line @DannyS03, the last few weeks have been wild |
Tracking issue: ipfs/js-kubo-rpc-client#36
Parent issue: ipfs/js-kubo-rpc-client#6
Originating issue: ipfs/kubo#9125
This PR is intended to update the docs so that users will be pointed to
kubo-rpc-client
instead ofipfs-http-client
when using Javascript/TypeScript to talk to Kubo.fixes ipfs/js-kubo-rpc-client#36
Things for reviewers to check: