-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to work-with-pinning-services.md #1653
Conversation
Co-authored-by: ElPaisano <113373882+ElPaisano@users.noreply.github.com>
@SgtPooki could I request a SME review from you on the Desktop / UI subsection in https://bafybeiabatbyptsnhjwnmkx2dercle7vbgcaqdtcohtq36cjwaeieuls3m.on.fleek.co/how-to/work-with-pinning-services/#use-a-third-party-pinning-service? I'm asking the kubo folks to review the cli section |
@lidel and Kubo maintainers, could I request a quick SME review on https://bafybeiabatbyptsnhjwnmkx2dercle7vbgcaqdtcohtq36cjwaeieuls3m.on.fleek.co/how-to/work-with-pinning-services/#ipfs-kubo? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've fully read the page at https://bafybeiabatbyptsnhjwnmkx2dercle7vbgcaqdtcohtq36cjwaeieuls3m.on.fleek.co/how-to/work-with-pinning-services/ and it seems sensible to me. Thanks for these updates!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for cleaning this up @ElPaisano, sgtm (two small nits inline)
Co-authored-by: Russell Dempsey <1173416+SgtPooki@users.noreply.github.com> Co-authored-by: Marcin Rataj <lidel@lidel.org>
Overhauls work-with-pinning-services.md and addresses #1638
The original scope of work was just reviewing and editing community-created #1638. However, digging into the page, I noticed multiple areas for improvement.
Note: GH action link check is flagging 403s, but I've checked those links and they work