Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to work-with-pinning-services.md #1653

Merged
merged 3 commits into from
Aug 31, 2023
Merged

Updates to work-with-pinning-services.md #1653

merged 3 commits into from
Aug 31, 2023

Conversation

ElPaisano
Copy link
Contributor

@ElPaisano ElPaisano commented Aug 3, 2023

Overhauls work-with-pinning-services.md and addresses #1638

The original scope of work was just reviewing and editing community-created #1638. However, digging into the page, I noticed multiple areas for improvement.

Note: GH action link check is flagging 403s, but I've checked those links and they work

kichen1984 and others added 2 commits August 3, 2023 13:14
Co-authored-by: ElPaisano <113373882+ElPaisano@users.noreply.github.com>
@ElPaisano ElPaisano requested a review from SgtPooki August 3, 2023 21:53
@ElPaisano
Copy link
Contributor Author

ElPaisano commented Aug 3, 2023

@SgtPooki could I request a SME review from you on the Desktop / UI subsection in https://bafybeiabatbyptsnhjwnmkx2dercle7vbgcaqdtcohtq36cjwaeieuls3m.on.fleek.co/how-to/work-with-pinning-services/#use-a-third-party-pinning-service? I'm asking the kubo folks to review the cli section

@ElPaisano ElPaisano marked this pull request as ready for review August 3, 2023 21:57
@ElPaisano ElPaisano changed the title Updates to work-with-pinning-services.mdUpdates Updates to work-with-pinning-services.md Aug 4, 2023
@ElPaisano
Copy link
Contributor Author

@lidel and Kubo maintainers, could I request a quick SME review on https://bafybeiabatbyptsnhjwnmkx2dercle7vbgcaqdtcohtq36cjwaeieuls3m.on.fleek.co/how-to/work-with-pinning-services/#ipfs-kubo?

@ElPaisano ElPaisano requested a review from lidel August 8, 2023 16:16
@BigLep BigLep requested a review from hacdias August 8, 2023 16:57
Copy link
Member

@hacdias hacdias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've fully read the page at https://bafybeiabatbyptsnhjwnmkx2dercle7vbgcaqdtcohtq36cjwaeieuls3m.on.fleek.co/how-to/work-with-pinning-services/ and it seems sensible to me. Thanks for these updates!

Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for cleaning this up @ElPaisano, sgtm (two small nits inline)

docs/how-to/work-with-pinning-services.md Outdated Show resolved Hide resolved
docs/how-to/work-with-pinning-services.md Outdated Show resolved Hide resolved
docs/how-to/work-with-pinning-services.md Outdated Show resolved Hide resolved
docs/how-to/work-with-pinning-services.md Outdated Show resolved Hide resolved
docs/how-to/work-with-pinning-services.md Outdated Show resolved Hide resolved
docs/how-to/work-with-pinning-services.md Outdated Show resolved Hide resolved
docs/how-to/work-with-pinning-services.md Outdated Show resolved Hide resolved
Co-authored-by: Russell Dempsey <1173416+SgtPooki@users.noreply.github.com>
Co-authored-by: Marcin Rataj <lidel@lidel.org>
@ElPaisano ElPaisano merged commit dea4970 into main Aug 31, 2023
4 of 5 checks passed
@ElPaisano ElPaisano deleted the stage branch August 31, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants