Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added EOSC and ExPaNds.eu entries #1654

Merged
merged 2 commits into from
Aug 25, 2023
Merged

Conversation

twdragon
Copy link
Contributor

@twdragon twdragon commented Aug 6, 2023

Added presentations made for European Open Science Cloud Symposium, describing IPFS as a prospective solution for decentralized data sharing and provenance.

Files changed

  • docs/concepts/further-reading/academic-papers.md

Added presentations made for European Open Science Cloud Symposium, describing IPFS as a perspective solution for decentralized data sharing and provenance.
@welcome
Copy link

welcome bot commented Aug 6, 2023

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions and stakeholders linked/mentioned.
  • Your contribution itself is clear (grammar and spelling checked, any code blocks checked and commented) and in its best form. Follow the docs contribution guidelines if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on any missing things and potentially assigning a reviewer for high priority items.
  • The PR gets reviews, discussed and approvals as needed.
  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@ElPaisano ElPaisano self-requested a review August 7, 2023 21:09
Copy link
Contributor

@ElPaisano ElPaisano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @twdragon thank you for submitting this PR.

Two of the links you added are being flagged by the GH action link checker. I manually tested the links to confirm that they are not working. could you please update this PR with the correct links? Thank you.

See below for more info:

=========================> MARKDOWN LINK CHECK <=========================

FILE: docs/concepts/further-reading/academic-papers.md
[✖] https://elettra.eu/ → Status: 0 Error: ETIMEDOUT
    at Timeout.<anonymous> (/usr/local/lib/node_modules/markdown-link-check/node_modules/request/request.js:848:19)
    at listOnTimeout (node:internal/timers:569:17)
    at process.processTimers (node:internal/timers:512:7) {
  code: 'ETIMEDOUT',
  connect: true
}
[✖] https://pan-data.eu/sites/pan-data.eu/files/PaNdataODI-D6.1.pdf → Status: 0 Error: connect ECONNREFUSED 130.246.[39](https://github.com/ipfs/ipfs-docs/actions/runs/5778249928/job/15691793632?pr=1654#step:4:40).148:443
    at TCPConnectWrap.afterConnect [as oncomplete] (node:net:1495:16) {
  errno: -111,
  code: 'ECONNREFUSED',
  syscall: 'connect',
  address: '130.246.39.148',
  port: 443
}

12 links checked.

ERROR: 2 dead links found!
[✖] https://elettra.eu/ → Status: 0
[✖] https://pan-data.eu/sites/pan-data.eu/files/PaNdataODI-D6.1.pdf → Status: 0

=========================================================================

Once the links are fixed, we can get the PR in.

@ElPaisano ElPaisano added need/author-input Needs input from the original author status/blocked Unable to be worked further until needs are met labels Aug 7, 2023
@twdragon
Copy link
Contributor Author

twdragon commented Aug 8, 2023

@ElPaisano done, please, check again. One of the links is pure HTTP

Copy link
Contributor

@ElPaisano ElPaisano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing. Merging now

@ElPaisano ElPaisano merged commit 0e99474 into ipfs:main Aug 25, 2023
2 of 4 checks passed
@twdragon twdragon deleted the twdragon-papers-eosc branch August 31, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need/author-input Needs input from the original author status/blocked Unable to be worked further until needs are met
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants