Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove content related to legacy ipfs-ds-convert tool #1935

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

lidel
Copy link
Member

@lidel lidel commented Oct 2, 2024

The tool is being sunset: ipfs-inactive/ipfs-ds-convert#50 and the "default-profile" page here was focused on using the tool to convert form flatfs to now deprecated badgerv1. Not something we want users to do.

There is a lot of things in the document that may be a footgun.

For example:

The ipfs-ds-convert tool itself was not maintained since 2021 and go-ipfs v0.8.0 (!), and we actively want to do migrations different way (ipfs/kubo#10347 (comment))

No need to keep poor outdated copy of a subset of config.md#profiles Let's just remove this content.

The tool is being sunset:
ipfs-inactive/ipfs-ds-convert#50
and the "default-profile" page was focused on using the tool to convert
form flatfs to now deprecated badgerv1.

There is a lot of things in the document that may be a footgun,
causing people to waste time. The tool was nto maintained since 2021
and go-ipfs v0.8.0 (!).

Let's just remove this content.
Copy link
Member

@2color 2color left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lidel lidel merged commit 25987fc into main Oct 7, 2024
7 checks passed
@lidel lidel deleted the chore/remove-ipfs-ds-convert branch October 7, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants