Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.8.0 #157

Merged
merged 1 commit into from
Feb 18, 2022
Merged

Release v1.8.0 #157

merged 1 commit into from
Feb 18, 2022

Conversation

aschmahmann
Copy link
Contributor

No description provided.

@aschmahmann aschmahmann requested a review from guseggert February 1, 2022 16:55
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to use go-ipfs v0.9.0-rc1, we should bump it to stable release 0.11.0

@github-actions
Copy link

Suggested version: v1.8.0
Comparing to: v1.7.1 (diff)

Changes in go.mod file(s):

diff --git a/go.mod b/go.mod
index 05494aa..47eb808 100644
--- a/go.mod
+++ b/go.mod
@@ -1,12 +1,12 @@
 module github.com/ipfs/ipfs-update
 
-go 1.15
+go 1.16
 
 require (
 	github.com/blang/semver v3.5.1+incompatible
-	github.com/ipfs/go-ipfs v0.8.1-0.20210331210551-bb8260abe11b
-	github.com/ipfs/go-ipfs-api v0.2.0
+	github.com/ipfs/go-ipfs v0.12.0
+	github.com/ipfs/go-ipfs-api v0.3.0
 	github.com/urfave/cli/v2 v2.3.0
 	github.com/whyrusleeping/stump v0.0.0-20160611222256-206f8f13aae1
-	golang.org/x/sys v0.0.0-20210309074719-68d13333faf2
+	golang.org/x/sys v0.0.0-20211025112917-711f33c9992c
 )

gorelease says:

# github.com/ipfs/ipfs-update/config
## incompatible changes
CurrentVersionNumber: value changed from "1.7.1" to "1.8.0-dev"

# github.com/ipfs/ipfs-update/lib
## incompatible changes
(*IpfsFetcher).Fetch: changed from func(context.Context, string) (io.ReadCloser, error) to func(context.Context, string) ([]byte, error)
## compatible changes
(*IpfsFetcher).Close: added

# summary
Cannot suggest a release version.
Incompatible changes were detected.

gocompat says:

(empty)

@aschmahmann
Copy link
Contributor Author

Merging as v1.8.0 instead of doing a major version bump since in any event the conflicting versions of the go-ipfs (which is pre v2) make it not doable to import this package as v1 and v2 together. Also, this is a binary not normally used as a package so doing a major bump seems unnecessary.

@aschmahmann aschmahmann merged commit e942f32 into master Feb 18, 2022
@aschmahmann aschmahmann deleted the release-v1.8.0 branch February 18, 2022 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants