Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Files: better labels for copying shareable link and CID #1327

Closed
lidel opened this issue Nov 24, 2019 · 0 comments · Fixed by #1347
Closed

Files: better labels for copying shareable link and CID #1327

lidel opened this issue Nov 24, 2019 · 0 comments · Fixed by #1347
Assignees
@lidel
Labels
topic/design-front-end Front-end implementation of UX/UI work topic/design-ux UX strategy, research, not solely visual design

Comments

@lidel
Copy link
Member

lidel commented Nov 24, 2019 •
edited
Loading

Quick note that we need to unify labels related to copying CID and HTTP URL:

Current state

Web UI

2019-11-24_19-57

Companion extension

companion-2019-11-24_19-58_1

See also ipfs/ipfs-companion#745

Proposed change

Copy hash → Copy CID
Share → Share (leave as is) or more elaborate Copy link for sharing

As for onclick, perhaps both should act the same, either directly copy to clipboard, or show the popup that is currently only displayed for Share option.

Before I open PRs normalizing this situation, any thoughts / preferences?
@lidel lidel added topic/design-front-end Front-end implementation of UX/UI work topic/design-ux UX strategy, research, not solely visual design labels Nov 24, 2019
@lidel lidel mentioned this issue Dec 3, 2019
Closed
@lidel lidel self-assigned this Dec 3, 2019
lidel added a commit that referenced this issue Dec 3, 2019
@lidel
style: Copy CID & Share link
e3cb6d8 
Closes #1327
@lidel lidel mentioned this issue Dec 3, 2019
Merged
hacdias pushed a commit that referenced this issue Dec 4, 2019
@lidel @hacdias
style: Copy CID & Share link
1ce5957 
Closes #1327
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lidel lidel

Labels
topic/design-front-end Front-end implementation of UX/UI work topic/design-ux UX strategy, research, not solely visual design
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: sharing improvements ipfs/ipfs-webui
1 participant
@lidel