Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imports to directories with spaces fails #1733

Closed
justicenode opened this issue Mar 19, 2021 · 3 comments · Fixed by #1764
Closed

Imports to directories with spaces fails #1733

justicenode opened this issue Mar 19, 2021 · 3 comments · Fixed by #1764
Assignees
Labels
kind/bug A bug in existing code (including security flaws) status/in-progress In progress

Comments

@justicenode
Copy link

Describe the bug
File uploads to a mfs folder that has a space in its name will always fail

To Reproduce

  1. Create a folder with a space in the name
  2. try to upload a file to it

Expected behavior
the file showing up after a few seconds and the upload to not instantly fail

Screenshots

2021-03-19.12-28-35-1.mp4

Desktop (please complete the following information):

  • OS: Windows 10 v1909
  • Browser: Firefox developer edition v87.0b3 (64-Bit)
  • Version: UI v2.11.4 | Revision 69cd414

Additional context
The problem is with the request being uri encoded before getting sent to the go-ipfs daemon. If you have developer tools open and edit & resend the request replacing the %20 with a space it works fine.

@justicenode justicenode added the need/triage Needs initial labeling and prioritization label Mar 19, 2021
@welcome

This comment has been minimized.

@justicenode
Copy link
Author

bump @lidel

If theres any additional info I can provide let me know. I dont think I can solve this issue myself as I dont really know the codebase but I might have a look.

@lidel
Copy link
Member

lidel commented Apr 15, 2021

Thank you @justicenode – very good bug report. The code is indeed bit hairy, but the problem was limited to drag&drop.
This should be fixed in the next release: #1764

@lidel lidel added kind/bug A bug in existing code (including security flaws) and removed need/triage Needs initial labeling and prioritization labels Apr 15, 2021
@lidel lidel self-assigned this Apr 15, 2021
@lidel lidel added the status/in-progress In progress label Apr 15, 2021
lidel added a commit that referenced this issue Apr 15, 2021
lidel added a commit that referenced this issue Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug in existing code (including security flaws) status/in-progress In progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants