Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't build with nodejs v17 and npm v8 #1940

Closed
Tracked by #1965
Jorropo opened this issue Jun 6, 2022 · 6 comments
Closed
Tracked by #1965

Can't build with nodejs v17 and npm v8 #1940

Jorropo opened this issue Jun 6, 2022 · 6 comments
Labels
effort/hours Estimated to take one or several hours exp/intermediate Prior experience is likely helpful help wanted Seeking public contribution on this issue kind/maintenance Work required to avoid breaking changes or harm to project's status quo P1 High: Likely tackled by core team if no one steps up

Comments

@Jorropo
Copy link

Jorropo commented Jun 6, 2022

Version
e77afcb

Describe the bug
The README specify

With node >= 10 and npm >= 6.4.1 installed, run

https://github.com/ipfs/ipfs-webui#install
But with :

$ npm --version
8.12.1
$ node --version
v17.3.1

I get:

$ npm i
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: eslint-plugin-ava@12.0.0
npm WARN Found: eslint@7.21.0
npm WARN node_modules/eslint
npm WARN   peer eslint@"^5.0.0 || ^6.0.0 || ^7.0.0" from @typescript-eslint/eslint-plugin@4.15.2
npm WARN   node_modules/@typescript-eslint/eslint-plugin
npm WARN     peer @typescript-eslint/eslint-plugin@"^4.0.0" from eslint-config-react-app@6.0.0
npm WARN     node_modules/eslint-config-react-app
npm WARN     1 more (react-scripts)
npm WARN   18 more (@typescript-eslint/experimental-utils, ...)
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peer eslint@">=7.22.0" from eslint-plugin-ava@12.0.0
npm WARN node_modules/eslint-plugin-ava
npm WARN   eslint-plugin-ava@"^12.0.0" from ipfs-repo@12.0.0
npm WARN   node_modules/ipfs-repo
npm WARN 
npm WARN Conflicting peer dependency: eslint@8.17.0
npm WARN node_modules/eslint
npm WARN   peer eslint@">=7.22.0" from eslint-plugin-ava@12.0.0
npm WARN   node_modules/eslint-plugin-ava
npm WARN     eslint-plugin-ava@"^12.0.0" from ipfs-repo@12.0.0
npm WARN     node_modules/ipfs-repo
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: ipld-explorer-components@2.0.4
npm ERR! Found: i18next@21.6.10
npm ERR! node_modules/i18next
npm ERR!   i18next@"^21.6.10" from the root project
npm ERR!   peer i18next@">= 19.0.0" from react-i18next@11.15.3
npm ERR!   node_modules/react-i18next
npm ERR!     react-i18next@"^11.15.3" from the root project
npm ERR!     peer react-i18next@"^11.8.12" from ipld-explorer-components@2.0.4
npm ERR!     node_modules/ipld-explorer-components
npm ERR!       ipld-explorer-components@"2.0.4" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer i18next@"^20.1.0" from ipld-explorer-components@2.0.4
npm ERR! node_modules/ipld-explorer-components
npm ERR!   ipld-explorer-components@"2.0.4" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: i18next@20.6.1
npm ERR! node_modules/i18next
npm ERR!   peer i18next@"^20.1.0" from ipld-explorer-components@2.0.4
npm ERR!   node_modules/ipld-explorer-components
npm ERR!     ipld-explorer-components@"2.0.4" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! See /home/hugo/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/hugo/.npm/_logs/2022-06-06T15_50_52_239Z-debug-0.log
# npm resolution error report

2022-06-06T15:52:01.917Z

While resolving: ipld-explorer-components@2.0.4
Found: i18next@21.6.10
node_modules/i18next
  i18next@"^21.6.10" from the root project
  peer i18next@">= 19.0.0" from react-i18next@11.15.3
  node_modules/react-i18next
    react-i18next@"^11.15.3" from the root project
    peer react-i18next@"^11.8.12" from ipld-explorer-components@2.0.4
    node_modules/ipld-explorer-components
      ipld-explorer-components@"2.0.4" from the root project

Could not resolve dependency:
peer i18next@"^20.1.0" from ipld-explorer-components@2.0.4
node_modules/ipld-explorer-components
  ipld-explorer-components@"2.0.4" from the root project

Conflicting peer dependency: i18next@20.6.1
node_modules/i18next
  peer i18next@"^20.1.0" from ipld-explorer-components@2.0.4
  node_modules/ipld-explorer-components
    ipld-explorer-components@"2.0.4" from the root project

Fix the upstream dependency conflict, or retry
this command with --force, or --legacy-peer-deps
to accept an incorrect (and potentially broken) dependency resolution.

Raw JSON explanation object:

{
  "code": "ERESOLVE",
  "edge": {
    "type": "peer",
    "name": "i18next",
    "spec": "^20.1.0",
    "error": "INVALID",
    "from": {
      "name": "ipld-explorer-components",
      "version": "2.0.4",
      "location": "node_modules/ipld-explorer-components",
      "isWorkspace": false,
      "dependents": [
        {
          "type": "prod",
          "name": "ipld-explorer-components",
          "spec": "2.0.4",
          "from": {
            "location": "/home/hugo/Documents/Scripts/ipfs-webui"
          }
        }
      ]
    }
  },
  "dep": {
    "name": "i18next",
    "version": "20.6.1",
    "whileInstalling": {
      "name": "ipld-explorer-components",
      "version": "2.0.4",
      "path": "/home/hugo/Documents/Scripts/ipfs-webui/node_modules/ipld-explorer-components"
    },
    "location": "node_modules/i18next",
    "isWorkspace": false,
    "dependents": [
      {
        "type": "peer",
        "name": "i18next",
        "spec": "^20.1.0",
        "error": "INVALID",
        "from": {
          "name": "ipld-explorer-components",
          "version": "2.0.4",
          "location": "node_modules/ipld-explorer-components",
          "isWorkspace": false,
          "dependents": [
            {
              "type": "prod",
              "name": "ipld-explorer-components",
              "spec": "2.0.4",
              "from": {
                "location": "/home/hugo/Documents/Scripts/ipfs-webui"
              }
            }
          ]
        }
      }
    ]
  },
  "current": {
    "name": "i18next",
    "version": "21.6.10",
    "location": "node_modules/i18next",
    "isWorkspace": false,
    "dependents": [
      {
        "type": "prod",
        "name": "i18next",
        "spec": "^21.6.10",
        "from": {
          "location": "/home/hugo/Documents/Scripts/ipfs-webui"
        }
      },
      {
        "type": "peer",
        "name": "i18next",
        "spec": ">= 19.0.0",
        "from": {
          "name": "react-i18next",
          "version": "11.15.3",
          "location": "node_modules/react-i18next",
          "isWorkspace": false,
          "dependents": [
            {
              "type": "prod",
              "name": "react-i18next",
              "spec": "^11.15.3",
              "from": {
                "location": "/home/hugo/Documents/Scripts/ipfs-webui"
              }
            },
            {
              "type": "peer",
              "name": "react-i18next",
              "spec": "^11.8.12",
              "from": {
                "name": "ipld-explorer-components",
                "version": "2.0.4",
                "location": "node_modules/ipld-explorer-components",
                "isWorkspace": false,
                "dependents": [
                  {
                    "type": "prod",
                    "name": "ipld-explorer-components",
                    "spec": "2.0.4",
                    "from": {
                      "location": "/home/hugo/Documents/Scripts/ipfs-webui"
                    }
                  }
                ]
              }
            }
          ]
        }
      }
    ]
  },
  "peerConflict": {
    "current": {
      "name": "i18next",
      "version": "21.6.10",
      "location": "node_modules/i18next",
      "isWorkspace": false,
      "dependents": [
        {
          "type": "prod",
          "name": "i18next",
          "spec": "^21.6.10",
          "from": {
            "location": "/home/hugo/Documents/Scripts/ipfs-webui"
          }
        },
        {
          "type": "peer",
          "name": "i18next",
          "spec": ">= 19.0.0",
          "from": {
            "name": "react-i18next",
            "version": "11.15.3",
            "location": "node_modules/react-i18next",
            "isWorkspace": false,
            "dependents": [
              {
                "type": "prod",
                "name": "react-i18next",
                "spec": "^11.15.3",
                "from": {
                  "location": "/home/hugo/Documents/Scripts/ipfs-webui"
                }
              },
              {
                "type": "peer",
                "name": "react-i18next",
                "spec": "^11.8.12",
                "from": {
                  "name": "ipld-explorer-components",
                  "version": "2.0.4",
                  "location": "node_modules/ipld-explorer-components",
                  "isWorkspace": false,
                  "dependents": [
                    {
                      "type": "prod",
                      "name": "ipld-explorer-components",
                      "spec": "2.0.4",
                      "from": {
                        "location": "/home/hugo/Documents/Scripts/ipfs-webui"
                      }
                    }
                  ]
                }
              }
            ]
          }
        }
      ]
    },
    "peer": {
      "name": "i18next",
      "version": "20.6.1",
      "whileInstalling": {
        "name": "ipld-explorer-components",
        "version": "2.0.4",
        "path": "/home/hugo/Documents/Scripts/ipfs-webui/node_modules/ipld-explorer-components"
      },
      "location": "node_modules/i18next",
      "isWorkspace": false,
      "dependents": [
        {
          "type": "peer",
          "name": "i18next",
          "spec": "^20.1.0",
          "error": "INVALID",
          "from": {
            "name": "ipld-explorer-components",
            "version": "2.0.4",
            "location": "node_modules/ipld-explorer-components",
            "isWorkspace": false,
            "dependents": [
              {
                "type": "prod",
                "name": "ipld-explorer-components",
                "spec": "2.0.4",
                "from": {
                  "location": "/home/hugo/Documents/Scripts/ipfs-webui"
                }
              }
            ]
          }
        }
      ]
    }
  },
  "strictPeerDeps": false,
  "force": false,
  "isMine": true
}
@Jorropo Jorropo added the need/triage Needs initial labeling and prioritization label Jun 6, 2022
@lidel lidel moved this to Todo in IPFS-GUI (PL EngRes) Jun 6, 2022
@lidel lidel moved this from Todo to Planned in IPFS-GUI (PL EngRes) Jun 6, 2022
@lidel lidel added exp/intermediate Prior experience is likely helpful P1 High: Likely tackled by core team if no one steps up kind/maintenance Work required to avoid breaking changes or harm to project's status quo effort/hours Estimated to take one or several hours help wanted Seeking public contribution on this issue and removed need/triage Needs initial labeling and prioritization labels Jun 6, 2022
@lidel
Copy link
Member

lidel commented Jun 24, 2022

@SgtPooki @hacdias I guess this is blocked / depends on #1840 ?

@SgtPooki
Copy link
Member

I just want to clarify that this error is for npm install and not npm run build

@Jorropo
Copy link
Author

Jorropo commented Jun 30, 2022

It is with npm install.
I can't try npm run build because it wont work if I didn't npm install first (which fails) so I can't try npm run build.

I guess I could install with old version and then run build with newer but that just silly. If I downgrade (which I did), I'm just gonna use the downgraded version for everything.

@SgtPooki
Copy link
Member

SgtPooki commented Jul 5, 2022

Related to this is a PR to keep badges showing LTS node versions (ones provided by github) that can build this package across all platforms via workflow action: #1962

@SgtPooki
Copy link
Member

SgtPooki commented Jul 9, 2022

@lidel @BigLep
I don't think we should support odd-numbered node versions.

Nodev17 is already unsupported. What do you think about closing this and adding a disclaimer in the readme that we will only support nodejs versions that are one of the following:

  • current
  • active LTS
  • maintenance LTS

This would also exclude v10 and v12, and then 14 next year (APR 2023).

@SgtPooki
Copy link
Member

Due to maintenance constraints, we're going to follow guidelines set in #1940 (comment) for node support. So Nodev17 is not supported. Please use 16.12.0 for the time being, or one of the node versions that can build successfully as shown by our node-versions CI runs and README

Repository owner moved this from Planned to Done in IPFS-GUI (PL EngRes) Jul 21, 2022
SgtPooki added a commit to ipfs/ipfs-gui that referenced this issue Aug 15, 2022
Document intentions behind ipfs/ipfs-webui#1940
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/hours Estimated to take one or several hours exp/intermediate Prior experience is likely helpful help wanted Seeking public contribution on this issue kind/maintenance Work required to avoid breaking changes or harm to project's status quo P1 High: Likely tackled by core team if no one steps up
Projects
No open projects
Archived in project
Development

No branches or pull requests

3 participants