Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add success notification on "set pinning" action #1979

Open
SgtPooki opened this issue Jul 19, 2022 · 2 comments
Open

feat: Add success notification on "set pinning" action #1979

SgtPooki opened this issue Jul 19, 2022 · 2 comments
Labels
area/screen/files Issues related to Files screen effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up P2 Medium: Good to have, but can wait until someone steps up

Comments

@SgtPooki
Copy link
Member

Currently, when we attempt to set pinning for a file, it will display a failure notification on failure, but we don't get any obvious feedback when the operation succeeds.

Example:

Currently, when I pin a file using a custom pinning provider (estuary) it succeeds, and the pin.status is "queued" but there is no visual indicator for this scenario. There are a few things going on here:

  1. We need a success notification
  2. We have a bug when displaying and handling "queued" pins

related to #1919

@SgtPooki SgtPooki added exp/novice Someone with a little familiarity can pick up P2 Medium: Good to have, but can wait until someone steps up area/screen/files Issues related to Files screen effort/hours Estimated to take one or several hours labels Jul 19, 2022
@SgtPooki SgtPooki moved this to To do in IPFS-GUI (PL EngRes) Jul 19, 2022
@xrazis
Copy link
Contributor

xrazis commented Aug 31, 2022

Hey @SgtPooki is something like this what you had in mind (with a valid reason ofc)?

image

Do you want a single message for pin/unpin events or would you prefer separate messages (ex successfully pinned / successfully unpinned).

@SgtPooki
Copy link
Member Author

@xrazis Yea that's what I had in mind. I think a separate message for pinned/unpinned would be ideal, but if that's much more work than we can stick with a singular message for now

xrazis added a commit to xrazis/ipfs-webui that referenced this issue Sep 29, 2022
@SgtPooki SgtPooki moved this from Needs Grooming to Planned / Backlog in IPFS-GUI (PL EngRes) Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/screen/files Issues related to Files screen effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up P2 Medium: Good to have, but can wait until someone steps up
Projects
No open projects
Status: Planned / Backlog
Development

No branches or pull requests

2 participants