Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The colours of the bandwidth graph and gauges for in/out are switched #876

Closed
lanzafame opened this issue Nov 2, 2018 · 2 comments
Closed

The colours of the bandwidth graph and gauges for in/out are switched #876

lanzafame opened this issue Nov 2, 2018 · 2 comments
Assignees
@fsdiogo
Labels
kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up

Comments

@lanzafame
Copy link
Contributor

1541153981
1541153988
The orange is incoming on the gauge but out on the timeline graph. The look great otherwise 😄
@olizilla
Copy link
Member

olizilla commented Nov 2, 2018 •
edited
Loading

derp derp derp. Thank you for your vigilance @lanzafame

@lanzafame
Copy link
Contributor Author

caveat, i am not sure whether the entire graph is entirely wrong or if just the legend is, so I will leave that to you to figure out 🙂

@olizilla olizilla added kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up labels Nov 5, 2018
@fsdiogo fsdiogo mentioned this issue Nov 5, 2018
Merged
@ghost ghost assigned fsdiogo Nov 5, 2018
@ghost ghost added the status/in-progress In progress label Nov 5, 2018
olizilla pushed a commit that referenced this issue Nov 6, 2018
@fsdiogo @olizilla
fix: speedometer colors (#881)
34d812d 
The incoming bandwidth "speedo" color now matches the bandwidth in color on the bandwidth over time color. Previously the in and out colors were swapped.

Fixes #876
@ghost ghost removed the status/in-progress In progress label Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fsdiogo fsdiogo

Labels
kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@olizilla @lanzafame @fsdiogo