Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spacebar selection does not work in Firefox #889

Closed
lidel opened this issue Nov 26, 2018 · 0 comments · Fixed by #905
Closed

Spacebar selection does not work in Firefox #889

lidel opened this issue Nov 26, 2018 · 0 comments · Fixed by #905
Assignees
@olizilla
Labels
exp/intermediate Prior experience is likely helpful kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up

Comments

@lidel
Copy link
Member

lidel commented Nov 26, 2018

In Files screen we can use keyboard arrow keys to move between files.
Pressing Spacebar adds file to selection (checkbox), but it only works in Chrome.
In Firefox checkbox gets selected and then instantly unchecked.

(keyboard navigation is important for Accessibility ipfs/ipfs-gui#28)
@lidel lidel added the kind/bug A bug in existing code (including security flaws) label Nov 26, 2018
@olizilla olizilla added P1 High: Likely tackled by core team if no one steps up exp/intermediate Prior experience is likely helpful status/ready Ready to be worked labels Dec 12, 2018
olizilla added a commit that referenced this issue Dec 13, 2018
@olizilla
fix: spacebar to select files on Firefox
eb10b01 
Use the keyup rather than keydown. keydown has always been weird.

fixes #889

License: MIT
Signed-off-by: Oli Evans <oli@tableflip.io>
@olizilla olizilla mentioned this issue Dec 13, 2018
Merged
@ghost ghost assigned olizilla Dec 13, 2018
@ghost ghost added status/in-progress In progress and removed status/ready Ready to be worked labels Dec 13, 2018
fsdiogo pushed a commit that referenced this issue Dec 13, 2018
@olizilla @fsdiogo
fix: spacebar file select in Firefox (#905)
515d86c 
Use the keyup rather than keydown to support Firefox.

Fixes #889.
@ghost ghost removed the status/in-progress In progress label Dec 13, 2018
@olizilla olizilla mentioned this issue Feb 25, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olizilla olizilla

Labels
exp/intermediate Prior experience is likely helpful kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix spacebar file select ff ipfs/ipfs-webui
2 participants
@olizilla @lidel