fix: updated languages.json using lol #1483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidel
approved these changes
Apr 30, 2020
There was a problem hiding this comment.
LGTM, thank you!
We don't have any automation for this,
I just realized I forgot to run lol when new languages were added.. 😢
@rafaelramalho19 worth reading: https://github.com/ipfs-shipyard/ipfs-webui/blob/master/docs/LOCALIZATION.md
lidel
changed the title
|
Ups 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like language choices were displaying as "English" in the choose-language modal due to their being missing from
languages.json.languages.jsonafter manually runninglol, this PR addresses that.lolis being run automatically and updatinglanguages.jsonas some part of our deploy process, and I missed that, there's a larger problem as of yet unresolved.Closes #1471