bug: tweak map height for sub-940px-high windows #1566
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes to how the peers map is displayed:
WorldMap.js
to 960px, to match the tachyons breakpoint that forces nav menu to top of screen (NOTE this is slightly unrelated to original issue, but tidies the landscape for thinking about this)window.innerHeight < 940
to address concerns raised in Map view takes up too much vertical space - pushes peer list too far down on smaller screens #1561 for users with small laptopsNote that to make this totally seamless for everyone, all the time, we'd really need to pull the peers page apart entirely and do something much more clever with truncating the map display for some window aspect ratios; I'd like to save that for a more substantial rework of the UI as a whole. However, this does keep the user from losing the peers list on smaller windows with non-extreme aspect ratios.
Screenshots (before on left, after on right)
1280 x 800, smallest current MacBook screen resolution:
965 x 570, just barely wider than the 960px nav menu breakpoint:
Closes #1561