Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: tweak map height for sub-940px-high windows #1566

Merged
merged 2 commits into from
Aug 3, 2020

Conversation

jessicaschilling
Copy link
Contributor

This PR makes the following changes to how the peers map is displayed:

  • Updates effective breakpoint in WorldMap.js to 960px, to match the tachyons breakpoint that forces nav menu to top of screen (NOTE this is slightly unrelated to original issue, but tidies the landscape for thinking about this)
  • Adds a "height breakpoint" of window.innerHeight < 940 to address concerns raised in Map view takes up too much vertical space - pushes peer list too far down on smaller screens #1561 for users with small laptops
    • If window height is less than 940px, map height is 0.6 * window height, minus 180px allowance for furniture (search bar and "Add connection" button)

Note that to make this totally seamless for everyone, all the time, we'd really need to pull the peers page apart entirely and do something much more clever with truncating the map display for some window aspect ratios; I'd like to save that for a more substantial rework of the UI as a whole. However, this does keep the user from losing the peers list on smaller windows with non-extreme aspect ratios.

Screenshots (before on left, after on right)

1280 x 800, smallest current MacBook screen resolution:
image

965 x 570, just barely wider than the 960px nav menu breakpoint:
image

Closes #1561

@jessicaschilling jessicaschilling merged commit a363876 into master Aug 3, 2020
@jessicaschilling jessicaschilling deleted the bug/map-vertical-size branch August 3, 2020 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Map view takes up too much vertical space - pushes peer list too far down on smaller screens
4 participants