Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: files pin status now shows correctly #1633

Merged
merged 1 commit into from
Sep 15, 2020
Merged

fix: files pin status now shows correctly #1633

merged 1 commit into from
Sep 15, 2020

Conversation

rafaelramalho19
Copy link
Contributor

Fixes #1621

lidel
lidel approved these changes Sep 15, 2020
View reviewed changes
Copy link
Member

@lidel lidel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, .toString() should be enough: both CIDs come from the same source.

(When we get a CID from unknown third party, then .toV1().toBaseEncodedString('base32') is safer as always produces CID in deterministic version and base)

@rafaelramalho19 rafaelramalho19 merged commit 94ada6a into master Sep 15, 2020
@rafaelramalho19 rafaelramalho19 deleted the chore/fix-files-pin-status branch September 15, 2020 15:41
@Gozala
Copy link
Contributor

Gozala commented Sep 15, 2020

.toV1().toBaseEncodedString('base32')

Note that toBaseEncodedString was / is been deprecated so toString('base32') would be a way to go.

@jessicaschilling jessicaschilling mentioned this pull request Sep 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidel lidel lidel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The PIN icon disappears unexpectedly
3 participants
@rafaelramalho19 @Gozala @lidel